Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training fraction and end date allowed at the same time in config #27

Closed
anders-kiaer opened this issue Apr 24, 2020 · 0 comments · Fixed by #95
Closed

Training fraction and end date allowed at the same time in config #27

anders-kiaer opened this issue Apr 24, 2020 · 0 comments · Fixed by #95
Labels
invalid This doesn't seem right

Comments

@anders-kiaer
Copy link
Collaborator

Original authour: @wouterjdb

If you set both the training set fraction and end date you'll get the following warning when running FlowNet:

Training set fraction and training set end date are both defined in config file.
The input given for training set fraction will be ignored.
The training set end date will be used to calculate the training set fraction.

I'd actually suggest to let the config parser handle this and stop execution early on. A warning during execution is a bit 'too silent' if you ask me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant