Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Fabric Terraform Resources and Data sources for latest Fabric … #799

Merged
merged 2 commits into from
Oct 21, 2024
Merged

fix: Update Fabric Terraform Resources and Data sources for latest Fabric … #799

merged 2 commits into from
Oct 21, 2024

Conversation

thogarty
Copy link
Contributor

  • Upgrade equinix-sdk-go to v0.46.0
  • Update Port models to match changes in new Fabric SDK
  • Update SimplifiedAccount to match changes in new Fabric SDK

@thogarty thogarty requested review from a team as code owners October 16, 2024 22:11
@ctreatma
Copy link
Contributor

Does this need to be synchronized with API deployment in any way?

  • Does this need to be released immediately because customers using existing versions of the TF provider are broken due to API changes?
  • Does this need to remain unreleased until after the API changes roll out (if 4.17 hasn't been released yet)?

@thogarty
Copy link
Contributor Author

Closes #798

@thogarty thogarty mentioned this pull request Oct 17, 2024
Closed
1 task
@thogarty
Copy link
Contributor Author

@ctreatma this should be released immediately to give customers a version that they can upgrade to once 4.17 API changes rollout. We do expect that early upgrades will break, but we would rather have that then not have a version available to customers that they can upgrade to for fixing the breaking issues.

The 4.17 API release is tomorrow evening (10/18)

displague
displague approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release notes will need to include a note that all configurations with equinix_fabric_port and equinix_fabric_ports will need to updated to the latest version.

Migration notes will need to be included if the state will not be safely updated in-place.

@thogarty
Copy link
Contributor Author

The release notes will need to include a note that all configurations with equinix_fabric_port and equinix_fabric_ports will need to updated to the latest version.

Migration notes will need to be included if the state will not be safely updated in-place.

Agree. The state should be able to be updated with a refresh with no other changes than an upgrade. Just modifying internal functionality and not the Terraform interface. Additionally, for ports we have no resources.

Merging this in.

@thogarty thogarty merged commit ca8dd81 into main Oct 21, 2024
8 of 11 checks passed
@thogarty thogarty deleted the update_fabric_resources_on_4.17_spec branch October 21, 2024 17:49
@github-actions GitHub Actions
Copy link

This PR is included in version 2.9.0 🎉

srushti-patl pushed a commit that referenced this pull request Oct 28, 2024
@thogarty @srushti-patl
fix: Update Fabric Terraform Resources and Data sources for latest Fa…
905bb85 
…bric … (#799)

* Upgrade equinix-sdk-go to v0.46.0
* Update Port models to match changes in new Fabric SDK
* Update SimplifiedAccount to match changes in new Fabric SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@displague displague displague approved these changes

@srushti-patl srushti-patl srushti-patl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thogarty @ctreatma @displague @srushti-patl