hard-code a 5-minute wait because that's what the API does

Author: ctreatma

test/e2e/vrfstest/vrf_route_test.go

@@ -4,8 +4,8 @@ import (
 	"regexp"
 	"strings"
 	"testing"
+	"time"
 
-	"github.com/equinix/equinix-sdk-go/services/metalv1"
 	root "github.com/equinix/metal-cli/internal/cli"
 	outputPkg "github.com/equinix/metal-cli/internal/outputs"
 	"github.com/equinix/metal-cli/internal/vrf"
@@ -127,7 +127,10 @@ func TestCli_Vrf_Route(t *testing.T) {
 					_ = helper.CreateTestVrfGateway(t, projectId.GetId(), ipReservation.VrfIpReservation.GetId(), vlan.GetId())
 					route := helper.CreateTestVrfRoute(t, vrf.GetId())
 
-					_ = helper.WaitForVrfRouteState(t, route.GetId(), metalv1.VRFROUTESTATUS_ACTIVE)
+					// We literally need to sleep for 5 minutes; the API will reject any
+					// VRF route update request that comes in less than 5 minutes after
+					// the VRF route was last updated
+					time.Sleep(300 * time.Second)
 
 					root.SetArgs([]string{subCommand, "update-route", "-i", route.GetId(), "-t", "foobar"})
 

test/helper/helper.go

@@ -28,7 +28,7 @@ func TestClient() *metalv1.APIClient {
 	configuration.AddDefaultHeader("X-Auth-Token", os.Getenv("METAL_AUTH_TOKEN"))
 	configuration.UserAgent = fmt.Sprintf("metal-cli/test-helper %s", configuration.UserAgent)
 	// For debug purpose
-	// configuration.Debug = true
+	configuration.Debug = true
 	apiClient := metalv1.NewAPIClient(configuration)
 	return apiClient
 }
@@ -188,33 +188,6 @@ func WaitForDeviceState(t *testing.T, deviceId string, states ...metalv1.DeviceS
 	return false, fmt.Errorf("timed out waiting for device %v state %v to become one of %v", deviceId, device.GetState(), states)
 }
 
-func WaitForVrfRouteState(t *testing.T, routeId string, statuses ...metalv1.VrfRouteStatus) bool {
-	var route *metalv1.VrfRoute
-	var err error
-	t.Helper()
-	predefinedTime := 900 * time.Second // Adjust this as needed
-	retryInterval := 10 * time.Second   // Adjust this as needed
-	startTime := time.Now()
-	client := TestClient()
-	for time.Since(startTime) < predefinedTime {
-		route, _, err = client.VRFsApi.FindVrfRouteById(context.Background(), routeId).Execute()
-		if err != nil {
-			t.Fatal(err)
-			return false
-		}
-		for _, status := range statuses {
-			if route.GetStatus() == status {
-				return true
-			}
-		}
-
-		// Sleep for the specified interval
-		time.Sleep(retryInterval)
-	}
-	t.Fatalf("timed out waiting for VRF route %v status %v to become one of %v", routeId, route.GetStatus(), statuses)
-	return false
-}
-
 func WaitForAttachVlanToPort(t *testing.T, portId string, attach bool) error {
 	t.Helper()
 	ticker := time.NewTicker(5 * time.Second)