Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPTL Dashboard Home Collection Updates (Biospecimen) #988

Closed
erincschwartz opened this issue Apr 26, 2024 · 10 comments · Fixed by NCI-C4CP/biospecimen#708
Closed

BPTL Dashboard Home Collection Updates (Biospecimen) #988

erincschwartz opened this issue Apr 26, 2024 · 10 comments · Fixed by NCI-C4CP/biospecimen#708
Assignees
Labels
CCC Priority 1 Issues to be addressed in the current release

Comments

@erincschwartz
Copy link
Collaborator

erincschwartz commented Apr 26, 2024

General edits:

  1. Automate advancing to next data entry field throughout all pages (currently requires FNL team to manually click into the next field)

Kit Assembly Screen:

  1. Change 'Tracking Number' to 'Return Kit Tracking Number'
  2. Add another field for 'Confirm Return Kit Tracking Number' and add programming to cross check the tracking number data to ensure a match

Image

Assign Kits Screen:

  1. Change 'Tracking Number' to 'Supply Kit Tracking Number'
  2. Add another field for 'Confirm Supply Kit Tracking Number' below

Image

and add programming to cross-check the tracking number data to ensure a match

Kit Shipment Screen:

  1. Change 'Scan tracking number' to 'Scan Supply Kit Tracking Number'

Image

Kits Receipt

  1. Change 'Scan Barcode' to 'Scan Return Kit Tracking Number'

Image

@erincschwartz erincschwartz converted this from a draft issue Apr 26, 2024
@sonyekere sonyekere added the CCC Priority 2 Issues will be prioritized in the upcoming/next release label Apr 29, 2024
@sonyekere sonyekere changed the title BPTL Dashboard Home Collection Updates BPTL Dashboard Home Collection Updates (Biospecimen) Apr 30, 2024
@sonyekere sonyekere moved this from Backlog to Development in Connect Development and Support Apr 30, 2024
@sonyekere sonyekere added CCC Priority 1 Issues to be addressed in the current release and removed CCC Priority 2 Issues will be prioritized in the upcoming/next release labels Apr 30, 2024
@erincschwartz
Copy link
Collaborator Author

Additional request on Kit Receipt screen:

  1. Add validation to ensure that the Collection ID matches the Collection ID (Cup ID) that was linked to the Return Kit Tracking Number during Kit Assembly
  2. Ensure that system does not partially write any data that doesn't save

Image

@amber-emmes
Copy link
Collaborator

I have submitted a PR to fix all front end level fixes requested here. However, I believe the following changes will require work on the connectFaas project and will require a separate pull request as a result:

  • Add validation to ensure that the Collection ID matches the Collection ID (Cup ID) that was linked to the Return Kit Tracking Number during Kit Assembly
  • Ensure that system does not partially write any data that doesn't save

@amber-emmes amber-emmes linked a pull request May 3, 2024 that will close this issue
@amber-emmes
Copy link
Collaborator

amber-emmes commented May 6, 2024

The Biospecimen-specific work is now in dev and ready for testing. That consists of all features except the two listed below:

  • Add validation to ensure that the Collection ID matches the Collection ID (Cup ID) that was linked to the Return Kit Tracking Number during Kit Assembly
  • Ensure that system does not partially write any data that doesn't save

@amber-emmes
Copy link
Collaborator

The connectFaaS work is now also ready for review in dev. This consists of the following work:

  • Add validation to ensure that the Collection ID matches the Collection ID (Cup ID) that was linked to the Return Kit Tracking Number during Kit Assembly
  • Ensure that system does not partially write any data that doesn't save

Please also generally re-test the Kit Receipt page to ensure the functionality looks good.

@erincschwartz
Copy link
Collaborator Author

@amber-emmes Testing this now.

Can you add "Kit" to "Return Kit Tracking Number" on Kit Assembly Screen?

Also, when attempting mis-matched tracking numbers on Assign Kits screen, the system will not allow (which is great) but there is no warning message. Can this be added? Similar to what you built into the Kit Assembly screen for the tracking number check would be great.

@erincschwartz
Copy link
Collaborator Author

@amber-emmes, I tested Kit Receipt page, it worked as expected and did not allow receipt of the wrong Collection ID. Tested functionality with correct Collection ID and everything looked good.

FYI, I will create an issue for next release to make error message more specific when Collection ID does not match what was originally linked to the Return Kit Tracking Number during kit assembly (will help FNL team and us understand the problem more quickly)

@amber-emmes
Copy link
Collaborator

Your two requested changes are now in dev and ready for re-testing. Please re-review both the Kit Assembly and Assign Kit screens to be safe. Thanks!

@Gbarra9
Copy link
Collaborator

Gbarra9 commented May 17, 2024

Added issue#1018 - BPTL home collection - return and supply kit tracking number persists

Tested in dev and ready for stage

@wyattks
Copy link
Collaborator

wyattks commented May 21, 2024

Tested in Stage. Ready for Prod.

@amber-emmes
Copy link
Collaborator

This is now in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCC Priority 1 Issues to be addressed in the current release
Projects
5 participants