Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouthwash kit receipt error in Biospecimen Dashboard ( May release) #981

Closed
erincschwartz opened this issue Apr 24, 2024 · 12 comments
Closed
Assignees
Labels
CCC Priority 1 Issues to be addressed in the current release

Comments

@erincschwartz
Copy link
Collaborator

FNL reported the following error when attempting to receipt mouthwash kit, Collection ID CHA000022 0007 in the Biospecimen Dashboard

Image

Prod data showed the tracking number as

Image

FNL reports that they did not receive any error messages after scanning the kit tracking number, they received the checkmark in the Dashboard.

@JoeArmani suggested FNL attempt to manually enter the tracking number with the parenthesis. FNL was able to receipt the kit and all receipt data populated on the back end.

@sonyekere
Copy link
Collaborator

Hi @erincschwartz is this also connected to issue #970 ?

@sonyekere sonyekere added the CCC Priority 2 Issues will be prioritized in the upcoming/next release label Apr 24, 2024
@erincschwartz
Copy link
Collaborator Author

@sonyekere I do not believe this is directly related to #970. @JoeArmani, thoughts?

@JoeArmani
Copy link
Collaborator

@sonyekere @erincschwartz I agree that it's a separate issue. It would probably be most efficient for a single developer to tackle the range of Home Collections issues for familiarity and also to avoid merge conflicts (if they're all resolved in the upcoming cycle).

@sonyekere sonyekere added CCC Priority 1 Issues to be addressed in the current release and removed CCC Priority 2 Issues will be prioritized in the upcoming/next release labels Apr 25, 2024
@sonyekere sonyekere changed the title Mouthwash kit receipt error in Biospecimen Dashboard Mouthwash kit receipt error in Biospecimen Dashboard ( May release) Apr 25, 2024
@sonyekere
Copy link
Collaborator

Thanks Both. @JoeArmani good point!

@amber-emmes
Copy link
Collaborator

This issue is currently planned to be resolved by automatically stripping non-numeric characters from barcodes entered in this field on the mouthwash kit receipt page.

  1. Is this as desired?
  2. Should any other pages, such as the mouthwash kit assembly and assign pages, also be updated to strip non-numeric inputs from entered tracking numbers?
  3. Will a data update script be needed to strip erroneous parentheses from existing data?

@JoeArmani
Copy link
Collaborator

@amber-emmes @erincschwartz Erin, please confirm/update this:

  1. The issue starts with the scan in 'Assemble Kits.' We need to eliminate this possibility throughout the process.
  2. Please ensure all the tracking number fields allow numeric input only. I'd mock the returned data from the scanner to make sure the process works as expected -- they will be using a scanner in real-time (not manual entry).
  3. We'll want to update those records in prod. There are only 4 records with this issue currently. @erincschwartz should this go into the prod changelog or are you expecting many more in the upcoming weeks?

@amber-emmes
Copy link
Collaborator

amber-emmes commented May 2, 2024

A PR to fix this going forward has been submitted; however, it will not fix the existing records in prod, which must be fixed separately. I would also like to see about updating the backend to strip non-numeric characters from tracking numbers to further harden this.

@erincschwartz
Copy link
Collaborator Author

We will request a prod change for existing records to coincide with the Prod release, as there may be more cases in the meantime if FNL team forgets to remove the parenthesis. That way, will not have to make multiple prod change requests.

@amber-emmes
Copy link
Collaborator

This is now in dev and ready for testing.

@sonyekere sonyekere moved this from Development to Testing in Connect Development and Support May 7, 2024
@wyattks
Copy link
Collaborator

wyattks commented May 7, 2024

Parenthesis automatically were removed when scanned in for the kit.

Tested in Dev. Ready for Stage.

@wyattks
Copy link
Collaborator

wyattks commented May 21, 2024

Tested in Stage. Ready for Prod.

@amber-emmes
Copy link
Collaborator

This is now in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCC Priority 1 Issues to be addressed in the current release
Projects
Development

No branches or pull requests

5 participants