Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR sequencing - ref Vietnam and Estonia #418

Closed
RichardMN opened this issue Sep 19, 2021 · 2 comments
Closed

PR sequencing - ref Vietnam and Estonia #418

RichardMN opened this issue Sep 19, 2021 · 2 comments

Comments

@RichardMN
Copy link
Collaborator

I think #413 and #417 are about ready to merge. I would suggest that Vietnam (#413) go first and then Estonia (#417) can be merged on top of that.

In early celebration of this, I have regenerated the hex sticker which shows what the logo will look like with Estonia and Vietnam both added:
https://github.com/RichardMN/covidregionaldata/blob/map-making/man/figures/logo.png

(There's probably some cunning way of merging this in later - there appears to be a slight coding error in our hexsticker code, and I am going to put in the lines for re-downloading the naturalearth packages so I don't have to google them every time.)

@seabbs
Copy link
Contributor

seabbs commented Sep 20, 2021

Lovely to see some more map coverage (especially outside of Western Europe). Both PRs are looking good and happy with either merge order (not clear which order is better TBH).

😆 yes please do put the package download scripts in as that cannot be fun.

@seabbs seabbs mentioned this issue Sep 20, 2021
@seabbs
Copy link
Contributor

seabbs commented Sep 27, 2021

Should all be merged in now and diffs fixed. Shall we update the map hex just before the next CRAN release?

@seabbs seabbs closed this as completed Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants