Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing warning message when deleting all hydrogen bonds between two chains #6615

Open
Zhirnoff opened this issue Mar 6, 2025 · 0 comments
Labels
Antisense Bucket: Antisense related issues Hydrogen bonds Bucket: Bugs related to Hydrogen bonds Priority: Medium Sequence mode Bucket: Sequence mode related issues Severity: High High level visibility to the user

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Mar 6, 2025

Description:
According to the requirements, if all hydrogen bonds between two chains are deleted, a warning message should appear. However, this message does not appear when all hydrogen bonds are removed, allowing the chains to separate without confirmation.

Steps to Reproduce

  1. Open Ketcher and draw two connected chains with hydrogen bonds between them. ( or open from file ketcher.zip)
  2. Select sense and antisense chains and right click
  3. Delete all hydrogen bonds between the two chains.
  4. Observe that no warning message appears, and the chains separate immediately.

Actual behavior
No warning appears, and the chains are separated without confirmation.

Expected behavior
A warning dialog should appear before the chains separate.
1.5. If all hydrogen bonds between two chains are deleted, the user should get a warning message with the title "Deletion of all Hydrogen Bonds", and the text: "Deleting all hydrogen bonds will cause the separation of two chains. Do you wish to proceed?", and options "Cancel" (default) and "Continue".

Video

2025-03-06_12h13_52.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 133.0.6943.127 (Official Build) (64-bit)

Ketcher version
[Version 3.2.0-rc.1]
Indigo version
[Version 1.30.0-rc.1]
This bug was found while testing #6254

@Zhirnoff Zhirnoff added Antisense Bucket: Antisense related issues Hydrogen bonds Bucket: Bugs related to Hydrogen bonds Priority: Medium Sequence mode Bucket: Sequence mode related issues Severity: High High level visibility to the user labels Mar 6, 2025
@Zhirnoff Zhirnoff added this to the Ketcher 3.2.0-rc.2 milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Antisense Bucket: Antisense related issues Hydrogen bonds Bucket: Bugs related to Hydrogen bonds Priority: Medium Sequence mode Bucket: Sequence mode related issues Severity: High High level visibility to the user
Projects
None yet
Development

No branches or pull requests

1 participant