Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection between molecule and monomer does not affect an amount of implicit hydrogens #6021

Closed
Tracked by #6600
rrodionov91 opened this issue Nov 27, 2024 · 1 comment · Fixed by #6229
Closed
Tracked by #6600

Connection between molecule and monomer does not affect an amount of implicit hydrogens #6021

rrodionov91 opened this issue Nov 27, 2024 · 1 comment · Fixed by #6229
Assignees
@Drimodaren
Labels
Ljubica found bugs Bucket: Bugs found by Ljubica on her daily routine Priority: High
Milestone
Ketcher 3.0.0-rc....

Comments

@rrodionov91
Copy link
Collaborator

Steps to Reproduce

  1. Go to Molecules mode
  2. Create any molecule with implicit hydrogen in any atom label
  3. Go to Macromolecules mode
  4. Add any monomer to canvas
  5. Connect monomer to molecule's atom with implicit hydrogen in label
    image

Actual behavior
Amount of hydrogens does not change when connect to monomer

Expected behavior
Amount of hydrogens should be reduced by one for each connection to monomer

Ketcher version [e.g. v2.4.2].
v2.27.0-rc.2
@rrodionov91 rrodionov91 added Priority: High Ljubica found bugs Bucket: Bugs found by Ljubica on her daily routine labels Nov 27, 2024
@Drimodaren Drimodaren self-assigned this Dec 20, 2024
@Drimodaren Drimodaren linked a pull request Dec 30, 2024 that will close this issue
6021 connection between molecule and monomer does not affect an amount of implicit hydrogens #6229
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 3, 2025

Tested. Bug fixed.

2025-01-03_12h23_07.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 131.0.6778.205 (Official Build) (64-bit)

Ketcher version
[Version 3.0.0-rc.1]
Indigo version
[Version 1.28.0-rc.1]

@AlexeyGirin AlexeyGirin mentioned this issue Mar 4, 2025
Open
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Drimodaren Drimodaren

Labels
Ljubica found bugs Bucket: Bugs found by Ljubica on her daily routine Priority: High
Projects
None yet
Milestone
Ketcher 3.0.0-rc.1 (Stability release)
3 participants
@rrodionov91 @Zhirnoff @Drimodaren