Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tail of Multi-Tailed Arrow is added to not the proper place on the Spine after the Redo action of removing the tail if the length of the spine were changed #5548

Closed
ivanmaslow opened this issue Sep 19, 2024 · 3 comments
Assignees
Labels
MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool Priority: Medium

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Sep 19, 2024

Steps to Reproduce

  1. Add default Multi-Tailed Arrow to Canvas:
    image
  2. Add a new tail by right-click
  3. Change the length of the spine by pulling the bottom tail down:
    image
  4. Right-click on the middle tail
  5. Click on Remove tail - tail is removed
  6. Click on Undo

Actual behavior

  • Tail is added to the middle of the spine:
    image

Expected behavior

  • Tail is added to the initial place

Environment details

  • Tested on RC SA environment
  • Ketcher [Version 2.25.0-rc.3] Build at 2024-09-18; 16:24:03
  • Indigo Version 1.24.0-rc.3.0-g692080c62-wasm32-wasm-clang-19.0.0
  • Windows 11 Enterprise
  • Chrome Version 128.0.6613.138 (Official Build) (64-bit)

Notes

@ivanmaslow
Copy link
Collaborator Author

Preview testing is completed on the nightly environment 5581-mmpk-issues:

  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-14; 08:25:46;
  • Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome, Version 129.0.6668.101 (Official Build) (64-bit)

Undo/Redo actions work correctly for the Multi-Tailed arrow added by Tool or from KET, including the case of Undo of removing of a tail:

chrome_cAGChHI4Xb.mp4

@yauhen-karmyzau
Copy link
Collaborator

Merged to Ketcher 2.26.0-rc.2

@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.26.0-rc.2 Build at 2024-10-14; 19:59:03
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool Priority: Medium
Projects
None yet
Development

No branches or pull requests

5 participants