Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the wexpect.py with the latest release of Wexpect #17

Closed
eoyilmaz opened this issue Feb 20, 2022 · 3 comments
Closed

Replace the wexpect.py with the latest release of Wexpect #17

eoyilmaz opened this issue Feb 20, 2022 · 3 comments
Assignees
Labels
feature request New feature request

Comments

@eoyilmaz
Copy link
Owner

Replace the wexpect.py with the latest release of Pexpect. I'm not very familiar with this module, and there is no comment in the code on why we have a wexpect.py instead of using the PyPI version of Pexpect. Reading the module documentation seems that this module is a modified version of a very old version of Pexpect. Using the modern version of Pexpect would benefit the code and possibly make the modifications obsolete.

@eoyilmaz eoyilmaz added the feature request New feature request label Mar 20, 2022
@p5k369
Copy link
Collaborator

p5k369 commented Mar 28, 2022

I think that's because of offering windows compatibility. https://pexpect.readthedocs.io/en/stable/overview.html#windows

@eoyilmaz eoyilmaz self-assigned this Jul 27, 2022
@eoyilmaz eoyilmaz changed the title Replace the wexpect.py with the latest release of Pexpect Replace the wexpect.py with the latest release of Wexpect Jun 5, 2024
@eoyilmaz
Copy link
Owner Author

eoyilmaz commented Jun 5, 2024

Apparently there is a PyPI version of Wexpect and it is completely written from scratch, and it is a drop in replacement. I tried using it but until we fix #367 it is not going to run properly, but it is promissing.

@eoyilmaz
Copy link
Owner Author

Our wexpect is working properly right now, and I feel we don't need to replace it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants