Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mutability for parameter defaults + add unit tests #231

Merged
merged 21 commits into from
Dec 27, 2022
Merged

fix mutability for parameter defaults + add unit tests #231

merged 21 commits into from
Dec 27, 2022

Conversation

eonu
Copy link
Owner

@eonu eonu commented Dec 27, 2022 •
edited
Loading

  • Fix CategoricalHMM and GaussianMixtureHMM parameter defaults for params/init_params being modified.
  • Fix CategoricalHMM and GaussianMixtureHMM unfreeze() calling super().freeze() instead of super().unfreeze().
  • Change load_digits numbers parameter name to digits.
  • Fix serialization/deserialization for _KNNMixin when weighting=None.
  • Change SequentialDataset properties to not return copies of arrays.
  • Remove SequentialDataset.__eq__.
  • Change HMMClassifier prior default to None.
  • Add unit tests.

@eonu eonu changed the base branch from master to dev December 27, 2022 15:00
@eonu eonu merged commit 738c921 into dev Dec 27, 2022
@eonu eonu deleted the add-tests branch December 27, 2022 16:33
@eonu eonu mentioned this pull request Dec 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eonu