Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Salvo] Use Salvo to measure real commits in Envoy repo #131

Closed
gyohuangxin opened this issue Mar 17, 2022 · 5 comments
Closed

[Salvo] Use Salvo to measure real commits in Envoy repo #131

gyohuangxin opened this issue Mar 17, 2022 · 5 comments
Labels

Comments

@gyohuangxin
Copy link
Member

Use Salvo to measure real commits in Envoy repo to find out what can be improve for Salvo and its test cases.
Then convert the example of fake commits to the real commits.

@gyohuangxin
Copy link
Member Author

@mum4k Sorry for the absence due to some critical work, I tried to measure real commits you mentioned before, but the commit id seems not be found from main branch in cloned repo.

$ git clone https://github.com/gyohuangxin/envoy && cd envoy
$ git checkout 461bec3bf2a29b56d1117f28df3a0894914d3952
fatal: reference is not a tree: 461bec3bf2a29b56d1117f28df3a0894914d3952

This commit id was 461bec3bf2a29b56d1117f28df3a0894914d3952
image

Do you have any idea about how to fix it?

@mum4k
Copy link
Contributor

mum4k commented Apr 7, 2022

I think 461bec3bf2a29b56d1117f28df3a0894914d3952 is a commit ID before envoyproxy/envoy#19115 was merged onto the main branch.

Envoy uses Squash commits, which means all commits reviewed in the PR get squashed together and result in a single commit into the main branch. We should be using this commit ID instead. This can be found in the conversation history of envoyproxy/envoy#19115 where it was merged in:

Screen Shot 2022-04-06 at 11 26 25 PM

Verified that this is available in a clone of the Envoy repository:

$ git clone https://github.com/envoyproxy/envoy && cd envoy
$ git log | grep 02dff6e0235e2f497fb57eb0b7c07cc091c538df
commit 02dff6e0235e2f497fb57eb0b7c07cc091c538df

@gyohuangxin
Copy link
Member Author

@mum4k Thank you, it confused me for a long time. Now it works.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 14 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 19, 2022
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

This issue has been automatically closed because it has not had activity in the last 104 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants