-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Salvo] Use Salvo to measure real commits in Envoy repo #131
Comments
@mum4k Sorry for the absence due to some critical work, I tried to measure real commits you mentioned before, but the commit id seems not be found from main branch in cloned repo.
This commit id was 461bec3bf2a29b56d1117f28df3a0894914d3952 Do you have any idea about how to fix it? |
I think Envoy uses Squash commits, which means all commits reviewed in the PR get squashed together and result in a single commit into the main branch. We should be using this commit ID instead. This can be found in the conversation history of envoyproxy/envoy#19115 where it was merged in: Verified that this is available in a clone of the Envoy repository:
|
@mum4k Thank you, it confused me for a long time. Now it works. |
This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 14 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had activity in the last 104 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions. |
Use Salvo to measure real commits in Envoy repo to find out what can be improve for Salvo and its test cases.
Then convert the example of fake commits to the real commits.
The text was updated successfully, but these errors were encountered: