Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hcr example no longer compiles #100

Closed
sainttttt opened this issue Oct 5, 2023 · 2 comments
Closed

hcr example no longer compiles #100

sainttttt opened this issue Oct 5, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@sainttttt
Copy link

Hi! After updating nimja and relevant packages after nim 2.0, the HCR example no longer compiles:

~/code/nimja/examples/hcr> nim c -r hcrex.nim
Hint: used config file '/Users/saint/.choosenim/toolchains/nim-2.0.0/config/nim.cfg' [Conf]
Hint: used config file '/Users/saint/.choosenim/toolchains/nim-2.0.0/config/config.nims' [Conf]
Hint: used config file '/Users/saint/.config/nim/config.nims' [Conf]
..................................................................................................................................................................................
/Users/saint/.nimble/pkgs2/jester-0.6.0-4834f85e61ae39f6b6acfb74d3bbba62d8779b66/jester.nim(1345, 9) Hint: Asynchronous route: match. [User]
/Users/saint/code/nimja/examples/hcr/hcrex.nim(19, 1) template/generic instantiation of `routes` from here
/Users/saint/.nimble/pkgs2/jester-0.6.0-4834f85e61ae39f6b6acfb74d3bbba62d8779b66/jester.nim(1351, 35) template/generic instantiation of `async` from here
/Users/saint/.choosenim/toolchains/nim-2.0.0/lib/pure/asyncmacro.nim(250, 31) Error: 'matchMatcher (Async)' is not GC-safe as it accesses 'to' which is a global using GC'ed memory
~/code/nimja/examples/hcr>

Thanks!

@enthus1ast
Copy link
Owner

enthus1ast commented May 3, 2024

Thank you, will have a look at it.

@enthus1ast enthus1ast mentioned this issue Aug 9, 2024
@enthus1ast enthus1ast added the documentation Improvements or additions to documentation label Aug 15, 2024
@enthus1ast
Copy link
Owner

The example builds again.
I think the Hot Code Reloading in general needs some love.
If someone uses it and finds some better implementation/improvements please pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants