Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle conflicting shortcuts in a nicer way. #7528

Closed
Tracked by #8032 ...
farmaazon opened this issue Aug 9, 2023 · 1 comment
Closed
Tracked by #8032 ...

Handle conflicting shortcuts in a nicer way. #7528

farmaazon opened this issue Aug 9, 2023 · 1 comment
Labels
d-hard Difficulty: significant prior knowledge required p-lowest Should be completed at some point x-chore Type: chore

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Aug 9, 2023

Follow up of #7527

The proper fix for conflicting shortcuts' problem should be to handle them by focus; The shortcuts in project view should not be global shortcuts, and the shortcuts should be handled "upwards": if the focused element does not handle a given shortcut, his parents should be checked one after another, and global shortcuts only then.

@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Aug 9, 2023
@farmaazon farmaazon added g-component-browser d-hard Difficulty: significant prior knowledge required p-low Low priority x-chore Type: chore labels Aug 9, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Aug 10, 2023
@jdunkerley jdunkerley added p-lowest Should be completed at some point and removed p-low Low priority labels Aug 31, 2023
@somebody1234
Copy link
Contributor

I'm assuming this is a non-issue in GUI2 due to bubbling of regular DOM events.

@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-hard Difficulty: significant prior knowledge required p-lowest Should be completed at some point x-chore Type: chore
Projects
Archived in project
Development

No branches or pull requests

3 participants