Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to list hidden tables #7142

Open
radeusgd opened this issue Jun 27, 2023 · 1 comment
Open

Ability to list hidden tables #7142

radeusgd opened this issue Jun 27, 2023 · 1 comment
Labels
-libs Libraries: New libraries to be implemented l-db-read Libraries: database reader x-new-feature Type: new feature request x-on-hold

Comments

@radeusgd
Copy link
Member

The PR #7072 introduced hidden tables used for the dry runs.

The tables are internal temporary tables, so they are not displayed to the user in the Connection.tables list.

However, sometimes the user may want to display them. So we want to add an option show_internal_enso_tables:Boolean = False that will allow to request (by setting it to True) to show these tables.

I did not add them straight away, because that will make the Connection.tables node very big, for a feature that is rarely needed.

This ticket should only be attempted once the new node design is completed and so we can make sure that the new show_internal_enso_tables flag is hidden by default and is displayed only once the node is expanded.

The implementation itself is trivial - we already have the logic in a private function get_tables_advanced. We just need to connect this logic and ensure that the newly added show_internal_enso_tables parameter is not displayed by default.

Once this is done, the get_tables_advanced will be practically equivalent to the main tables so they can be merged (the private method can be removed, implementation moved back to tables).

@radeusgd radeusgd added x-new-feature Type: new feature request -libs Libraries: New libraries to be implemented l-db-read Libraries: database reader labels Jun 27, 2023
@radeusgd
Copy link
Member Author

Blocked by #5922 (if I got the ticket right - precisely by the ability to have parameters that are not displayed by default and only show up when the node is expanded).

@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Jul 7, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to ❓New in Issues Board Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented l-db-read Libraries: database reader x-new-feature Type: new feature request x-on-hold
Projects
Status: New
Development

No branches or pull requests

2 participants