Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider creating file-lock to prevent multiple instances of project-manager being started #7103

Open
hubertp opened this issue Jun 22, 2023 · 4 comments
Assignees
Labels

Comments

@hubertp
Copy link
Collaborator

hubertp commented Jun 22, 2023

As suggested in #6857 (comment).

I guess one potential downside is making sure that project-manager cleans up that file lock on shutdown. And, as it is with shutdowns, they are not always done in a clean way.

@wdanilo
Copy link
Member

wdanilo commented Jun 26, 2023

Why multiple instances of project manager could not be started? We should allow for multiple instances of Enso (and in the future for tabbed projects). So, multiple engines are a very valid scenario.

@jdunkerley
Copy link
Member

The project manager launches separate language servers but we should only have project manager running on a machine.

We can then ensure we don't have 2 instance of language servers against the same project, but can have as many language servers against different projects as we wish.

The child process model of electron to launce the PM would need revisiting.

@wdanilo
Copy link
Member

wdanilo commented Jul 3, 2023

Oh, ok, if this will support multiple Enso instances then great. I was thinking that each instance requires a separate project manager.

@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Jul 19, 2023
@JaroslavTulach
Copy link
Member

potential downside is making sure that project-manager cleans up that file lock on shutdown

With CLIHandler that's not issue at all! Stale lock files are detected as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📤 Backlog
Development

No branches or pull requests

5 participants