Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure naming of Columns resulting from Column operations is consistent. #5157

Closed
wdanilo opened this issue Feb 5, 2023 · 0 comments · Fixed by #5850
Closed

Ensure naming of Columns resulting from Column operations is consistent. #5157

wdanilo opened this issue Feb 5, 2023 · 0 comments · Fixed by #5850
Assignees
Labels
-libs Libraries: New libraries to be implemented l-derived-columns p-low Low priority x-new-feature Type: new feature request

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by Radosław Waśko.
Original issue is here.


Currently in-memory operations call all resulting columns Result and DB operations inherit the name of the original column. That is inconsistent.

In other places we were discussing adding a new_name parameter to the operations so that the user can pick a new name.

The goal of this ticket is to fix both of these:

  • extend all column operations with a new_name parameter allowing to set the name of the operation's result.
  • come up with some sane defaults for the new_name and make sure that they are consistent between backends.

The algorithm for the default new_name could be:

  • <op name> of <original column name> for unary operations,
  • for binary operations it gets complicated as the operand may be another column or just an Enso object, we could do: <op name> of <original column name> and <other column name or objects's type> so stuff like Sum of A and B or Sum of A and a Text.
@jdunkerley jdunkerley removed this from Issues Board Feb 6, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Mar 8, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Mar 8, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to 👁️ Code review in Issues Board Mar 8, 2023
@jdunkerley jdunkerley added this to the Design Partners milestone Mar 8, 2023
@mergify mergify bot closed this as completed in #5850 Mar 10, 2023
@mergify mergify bot closed this as completed in 91ef8ac Mar 10, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Mar 10, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented l-derived-columns p-low Low priority x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants