Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlibs benchmark regressions 2025-02-24 #12374

Closed
Akirathan opened this issue Feb 26, 2025 · 3 comments · Fixed by #12375
Closed

stdlibs benchmark regressions 2025-02-24 #12374

Akirathan opened this issue Feb 26, 2025 · 3 comments · Fixed by #12375
Assignees
Labels
--low-performance --regression Important: regression -libs Libraries: New libraries to be implemented p-high Should be completed in the next sprint

Comments

@Akirathan
Copy link
Member

Several severe regressions in stdlib benchmarks on 2025-02-24. The non-exhaustive list of regressed benchmarks:

Image

All of these benchmarks used to be stable, and regressed by cca 1000% on 2025-02-24.

Good revision: 76f5f70
Bad revision: e74db0b
Range: 76f5f70...e74db0b

Looking into the benchmark run for ceil_decimal benchmark, it seems that that particular benchmark has insufficient warmup.

@Akirathan Akirathan added --low-performance --regression Important: regression -libs Libraries: New libraries to be implemented p-high Should be completed in the next sprint labels Feb 26, 2025
@Akirathan
Copy link
Member Author

Is it possible that #12295 caused these huge regressions?? cc @JaroslavTulach

@JaroslavTulach
Copy link
Member

JaroslavTulach commented Feb 27, 2025

Is it possible that #12295 caused these huge regressions?? cc @JaroslavTulach

I cannot exclude such an alternative. It might, for example, change the warmup characteristics.

Looking into the benchmark run for ceil_decimal benchmark, it seems that that particular benchmark has insufficient warmup.

Yeah, that's possible. There is this new transferToInterpreter() - there were recently doubts about usage of such construct.

@JaroslavTulach JaroslavTulach self-assigned this Feb 27, 2025
@JaroslavTulach JaroslavTulach moved this from ❓New to 👁️ Code review in Issues Board Feb 27, 2025
@Akirathan
Copy link
Member Author

Yeah, that's possible. There is this new transferToInterpreter() - there were recently doubts about usage of such construct.

Problems with transferToInterpreter revealed in another issue at #11437 (comment). So the very first step is to run with JAVA_OPTS='-Dpolyglot.engine.TraceTransferToInterpreter=true'

@mergify mergify bot closed this as completed in #12375 Feb 27, 2025
@mergify mergify bot closed this as completed in a11e071 Feb 27, 2025
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--low-performance --regression Important: regression -libs Libraries: New libraries to be implemented p-high Should be completed in the next sprint
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

2 participants