You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we seem to have little to no tests for Table.get_row (and DB_Table counterpart).
As noticed in a review, we actually have a bug in the DB_Table implementation - calling get_row -1 on an empty table will currently raise Index_Out_Of_Bounds error while the expected behaviour is to return if_missing value (Nothing) by default. This went unnoticed because we are lacking tests.
Add tests for get_row both on Table and DB_Table (may need a sort before to ensure consistent ordering in DB).
Specifically add tests for edge cases like empty table, especially get_row -1 but also perhaps get_row -1 and get_row -2 on row table.
The text was updated successfully, but these errors were encountered:
Currently we seem to have little to no tests for
Table.get_row
(andDB_Table
counterpart).As noticed in a review, we actually have a bug in the DB_Table implementation - calling
get_row -1
on an empty table will currently raiseIndex_Out_Of_Bounds
error while the expected behaviour is to returnif_missing
value (Nothing
) by default. This went unnoticed because we are lacking tests.get_row
both onTable
andDB_Table
(may need a sort before to ensure consistent ordering in DB).get_row -1
but also perhapsget_row -1
andget_row -2
on row table.The text was updated successfully, but these errors were encountered: