Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for DB_Table.get_row and fix a bug #12317

Open
2 tasks
radeusgd opened this issue Feb 18, 2025 · 0 comments
Open
2 tasks

Add tests for DB_Table.get_row and fix a bug #12317

radeusgd opened this issue Feb 18, 2025 · 0 comments
Labels
--bug Type: bug -libs Libraries: New libraries to be implemented

Comments

@radeusgd
Copy link
Member

Currently we seem to have little to no tests for Table.get_row (and DB_Table counterpart).

As noticed in a review, we actually have a bug in the DB_Table implementation - calling get_row -1 on an empty table will currently raise Index_Out_Of_Bounds error while the expected behaviour is to return if_missing value (Nothing) by default. This went unnoticed because we are lacking tests.

  • Add tests for get_row both on Table and DB_Table (may need a sort before to ensure consistent ordering in DB).
    • Specifically add tests for edge cases like empty table, especially get_row -1 but also perhaps get_row -1 and get_row -2 on row table.
@radeusgd radeusgd added --bug Type: bug -libs Libraries: New libraries to be implemented labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -libs Libraries: New libraries to be implemented
Projects
Status: New
Development

No branches or pull requests

1 participant