[client] "closed" event isn't triggered on socket disconnect

[andyrichardson]

About

When a socket is disconnected, the "closed" event isn't emitted

Reproduction

• Pull this reproduction
• Change the URL in the index.js to a valid endpoint
• Run yarn start
• Open browser and open console
• Disconnect device from the network

Expected result

The following events are logged in the console:

• connecting
• connected
• closed

Actual result

The following events are logged in the console:

• connecting
• connected

(no closed event)

Screenshot

Note: This issue is not exclusive to simulating offline network states (e.g. disconnecting device from network also has same result)

Debug Information

See repro

[andyrichardson]

Closing as this is better encapsulated by #117

[michelepra]

Online/Offline switch in chrome devtool not affect websocket connection.

To simulate connection lost in client side:

• ✂️ network cable (😱 please not do)
• disable network interface
• unplug network cable
• switch off wifi

If you have control of server

• stop application
• unplug network wire (virtual or phisical)

[enisdenjo]

As @michelepra said, the test case you provided is not valid. If you indeed think closed events are not dispatched, please do make a proper repro (or a failing test).