From cb6c5ecbe01309ebd8ab7edcc688e6e81f0c2609 Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Fri, 29 Sep 2023 13:37:24 -0700 Subject: [PATCH] [ci] Wait for LUCI test checkin in `release` (#4911) Avoid the possibilty of the `release` action's wait-for-all-tests step completing before any LUCI tests have even checked in, by first waiting for a known LUCI test to show up. --- .github/workflows/release.yml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3c236383528e6..6bdbc50201fd0 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -43,6 +43,22 @@ jobs: run: dart pub get working-directory: ${{ github.workspace }}/script/tool + # The next step waits for all tests, but when there are issues with the + # hooks it can take a long time for the tests to even be registered. If + # "Wait on all tests" runs before that happens, it will pass immediately + # because there doesn't appear to be anything to wait for. To avoid that, + # explicitly wait for one LUCI test by name first. + - name: Wait for test check-in + uses: lewagon/wait-on-check-action@e106e5c43e8ca1edea6383a39a01c5ca495fd812 + with: + ref: ${{ github.sha }} + check-name: 'Linux ci_yaml packages roller' + repo-token: ${{ secrets.GITHUB_TOKEN }} + wait-interval: 30 # seconds + allowed-conclusions: success,neutral + # verbose:true will produce too many logs that hang github actions web UI. + verbose: false + # This workflow should be the last to run. So wait for all the other tests to succeed. - name: Wait on all tests uses: lewagon/wait-on-check-action@e106e5c43e8ca1edea6383a39a01c5ca495fd812