Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ses: Permit Symbol.dispose, Symbol.asyncDispose #1927

Closed
kriskowal opened this issue Jan 8, 2024 · 3 comments
Closed

ses: Permit Symbol.dispose, Symbol.asyncDispose #1927

kriskowal opened this issue Jan 8, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024

Comments

@kriskowal
Copy link
Member

What is the Problem Being Solved?

Explicit Resource Management is Stage 3 and we should permit Symbol.dispose and Symbol.asyncDispose under Hardened JavaScript

@kriskowal kriskowal added the enhancement New feature or request label Jan 8, 2024
@kriskowal kriskowal self-assigned this Jan 8, 2024
@kriskowal kriskowal added kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 good first issue Good for newcomers labels Jan 8, 2024
@mhofman
Copy link
Contributor

mhofman commented Jan 8, 2024

I thought they were already added in #1578

@kriskowal
Copy link
Member Author

I see now that they were and why my grep didn’t reveal them. Thanks.

@dckc
Copy link
Contributor

dckc commented Jan 8, 2024

what package versions should this appear in?

looks like ses 0.18.5
https://github.com/endojs/endo/blob/master/packages/ses/NEWS.md#v0185-2023-07-14

yes, that explains why someone reported seeing

Removing intrinsics.Symbol.dispose
Removing intrinsics.Symbol.asyncDispose

after doing yarn create @agoric/dapp --dapp-template dapp-offer-up demo: that depends on [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024
Projects
None yet
Development

No branches or pull requests

3 participants