Using legacy BIOS with the manual partition option used, GRUB doesn’t get installed.

[CodePagesNet]

Please assign to me if you will.

Questions:

1. Does this apply to Grub on BIOS GPT as well as BIOS non-GPT?
2. Does "Legacy" refer to non-GPT BIOS or does "Legacy" cover anything non-EFI?

[dalto8]

I will let @killajoe answer your questions.

I can tell you that this an issue in partition module, not the bootloader module. However, I would do an upstream merge in a branch and see if this issue is already resolved.

I didn't do a merge yet because we are in a release cycle and I didn't want to risk introducing any breakage for such an obscure issue.

[killajoe]

Yes non got partition scheme (msdos)
Booted in non EFI mode.
Using manual partition option, minimal only one system partition, flagged as boot.
It does work on gpt creating grub on empty partition (grub drive?)

[dalto8]

To be clear, this is related to a kpmcore change. I believe it is has already been fixed upstream.

Specifically, there were changes made on Dec 20th and Dec 21st to address this issue.

[killajoe]

there were changes made on Dec 20th and Dec 21st to address this issue.

calamares@98f47ee

calamares@c335c7e

may this also ?
calamares@3e9eabe

May we should merge upstream changes before the release ;) nah better not ..
we can do after this and check with time...

[CodePagesNet]

To be clear, this is related to a kpmcore change.
I believe it is has already been fixed upstream.

I'm also an Endeavor OS fan and advocate so I'm happy to hear that these things are being resolved! :-)

Q. Were these things fixed in the official calamares repo, is that the idea here?

I'm gradually getting up to speed. In addition to basic bugs, certainly it's also good if as a particular distribution, the needs of Endeavor OS (and other distributions, e.g. I think I've seen some Manjaro relationship in my repo surfing) can feedback to core calamares as patterns (e.g. use cases) to be supported.

I didn't see a way to PM on Endeavor forum so if we use github as our forum for discussing code fixes/enhancements that's fine with me but I mention because dalto suggested PM.

I've studied some of the partition UI code. I also have the idea from the notes about convenient use of qt properties for some partition data. This weekend, I'll go through the three changes that hopefully resolve and at least I'll become more familiar and be an additional code review and provide any helpful feedback/suggestions.

[dalto8]

I didn't see a way to PM on Endeavor forum so if we use github as our forum for discussing code fixes/enhancements that's fine with me but I mention because dalto suggested PM.

If you click on a user you get a "Message" option.

The same thing happens if you go to their profile. There is a "Message" option. If you don't see it, let me know your username and I can ensure it isn't a trust level issue.

[CodePagesNet]

Hi Dalto, Yes, that is one of the things that I did, but this is what I get:

Thank you though.

[dalto8]

Yes, that is one of the things that I did, but this is what I get:

I can easily fix that, I just need your forum username.

[CodePagesNet]

...need your forum username.

Greg_M

(My full first name is Gregory, but Greg for short is fine.)

[dalto8]

Try now. You might need to logout and log back in.