Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Information Dialog Quits upon Data Entry at Full Name Form Field #60

Open
CodePagesNet opened this issue Jan 4, 2025 · 7 comments
Assignees

Comments

@CodePagesNet
Copy link

CodePagesNet commented Jan 4, 2025

This is a known issue and has been reported by me and other(s).
Form quits at Full Name field

The User Information dialog (not sure Dialog actual name) quits upon typing data at the Full Name form field. It's peculiar because other fields don't have this problem.

IMPORTANT: This errant behavior only happens under specific circumstances, so some users may never have a problem with it. For example, I noticed it after I had used PartitionManager. (I don't know if using gparted also causes it.) Other times, e.g. upon fresh boot, when I restarted the installation without using PartitionManager (because partitions already configured), the Full Name field caused no problems.

I'm working on the partition area now. I'll also look for this issue, so this bug may be assigned to me if you'd like.

@dalto8
Copy link

dalto8 commented Jan 4, 2025

Interesting. I have never seen that in my testing but, to your point, it may only happen in certain circumstances which I am not triggering.

Thanks for being willing to dive in and take a look at it. If you have any questions on Calamares as you look into it, feel free to PM me on the forum if I can help in any way.

@CodePagesNet CodePagesNet changed the title User Information Dialog Quits upon Typing Data at Full Name Form Field User Information Dialog Quits upon Data Entry at Full Name Form Field Jan 4, 2025
@killajoe
Copy link
Member

killajoe commented Jan 4, 2025

I noticed it after I had used PartitionManager. (I don't know if using gparted also causes it.) Other times, e.g. upon fresh boot, when I restarted the installation without using PartitionManager (because partitions already configured), the Full Name field caused no problems.

From my own experience, such things happen if using ISO writing tools like rufus or ventoy and others. In case, usb device not fully synced. Or using something that is changing the boot process of the hybrid ISO file (archiso). Thats the only time i was able to reproduce this issue back one day. Only to mention my research on that issue.

@CodePagesNet
Copy link
Author

CodePagesNet commented Jan 4, 2025

... feel free to PM me on the forum if I can help in any way.
Hi Dalto, thank you. I didn't see a way on forum to use PM. I have reviewed pkgbuild cmds and I'd like to perform routine builds as I work with the code, without entire pkgbuild process each time. From untouched repo, I have qt5 dependency issue and pkgbuild uses 6 so that's probably something that I can take care of, but again the overall goal is routine build as work with code without full pkgbuild. pkgbuild appears to be similar to setting up what would be on a live ISO to run the installer and this is fine for local testing also but I would like to simply build sometimes with a lesser process (e.g. recompile parts of code). I may also see if I can add some #ifdefs in certain parts of code to be able to test the installer UI without affecting my local system (perhaps such capabilities exist to some extent already as others may have had same idea for local testing).

@CodePagesNet
Copy link
Author

I've been familiarizing with the CMakeLists.txt and I do see now that the pkgbuild is a perfect guide for driving the CMake process - thanks Joe!

@dalto8
Copy link

dalto8 commented Jan 5, 2025

There is no right way to develop but I use Qt Creator for Calamares work. It can open the cmakelists directly and provide a full IDE including an interactive debugger. That makes troubleshooting the partition module a lot easier for me.

@CodePagesNet
Copy link
Author

Hi, something appears possibly amiss in calamares/src/modules/users/Config.cpp:

Notice in void Config::setFullName(), the first if statement checks name.isEmpty( ) and then does several things with it if it's empty as opposed to non-empty. I'm also not sure why (in that same code area) host name and login name would be set from full name or even set from an empty full name.

@dalto8
Copy link

dalto8 commented Jan 22, 2025

While it isn't the most readable code in the world, I think it is correct.

In Pseudo-code:
If the new fullname is empty but it wasn't previously then also clear the hostname and login name which were based on the fullname. Then set the fullname to empty and emit the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants