Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

UBAMonitorSlow not processed since commit "add check for max telegram length" #143

Closed
Vuego123 opened this issue Jun 30, 2019 · 1 comment
Closed

UBAMonitorSlow not processed since commit "add check for max telegram length" #143

Vuego123 opened this issue Jun 30, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@Vuego123
Copy link
Contributor

Since commit "add check for max telegram length" (4b28a1d) the UBAMonitorSlow messages are no longer processed. Is the max telegram length check too strict?

An example of how the 0x19 UBAMonitorSlow looks with version 1.8

(00:02:30.536) Boiler -> all, type 0x19 telegram: 88 00 19 00 00 DC 80 00 80 00 FF FF 00 00 00 21 9A 06 E1 7C 00 00 00 06 C2 13 00 1E 90 80 00 (CRC=36) #data=27
<--- UBAMonitorSlow(0x19)
@Vuego123 Vuego123 added the bug Something isn't working label Jun 30, 2019
@proddy
Copy link
Collaborator

proddy commented Jul 1, 2019

well spotted, fixed!

@proddy proddy closed this as completed Jul 1, 2019
@proddy proddy mentioned this issue Jul 1, 2019
Closed
proddy added a commit that referenced this issue Jul 1, 2019
@proddy
https://github.com/proddy/EMS-ESP/issues/143
74abec2
@nhmariend nhmariend mentioned this issue Jun 1, 2020
Closed
@cyniu88 cyniu88 mentioned this issue Sep 14, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@proddy @Vuego123