Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add the option to automatically collapse large messages #1232

Closed
TommyDuc opened this issue Feb 7, 2023 · 6 comments
Closed

[Feature] Add the option to automatically collapse large messages #1232

TommyDuc opened this issue Feb 7, 2023 · 6 comments
Assignees
Labels
desktop MQTTX Desktop feature This pr is a feature web MQTTX Web
Milestone

Comments

@TommyDuc
Copy link

TommyDuc commented Feb 7, 2023

Motivation

Large messages (read about ~100MB) are fetched and displayed as is by MQTTX.
Not only is this not practical but it also makes the application lag and even crash.

Detailed design

There should be a limit for the maximum length for messages being displayed.
If that limit was exceeded then the message should be automatically collapsed.

@TommyDuc TommyDuc added the feature This pr is a feature label Feb 7, 2023
@ysfscream ysfscream self-assigned this Feb 8, 2023
@ysfscream ysfscream added the desktop MQTTX Desktop label Feb 8, 2023
@Red-Asuka
Copy link
Member

Thank you for bringing this to our attention. We hadn't considered the display issue with large messages before. I will take your suggestion into account and work to implement it as soon as possible.

@ysfscream ysfscream added the web MQTTX Web label Feb 8, 2023
@ysfscream ysfscream assigned Red-Asuka and unassigned ysfscream Feb 8, 2023
@TommyDuc
Copy link
Author

TommyDuc commented Feb 8, 2023

Thanks @Red-Asuka !

@ysfscream
Copy link
Member

ysfscream commented Feb 9, 2023

@TommyDuc Hi, before we optimize this, could I ask you two questions?

  1. What is the scenario that requires such a large size of data?
  2. What is the current performance and show of MQTT X when receiving and sending this large amount of data?

We want to be able to reproduce this when optimizing fully. Thanks

@TommyDuc
Copy link
Author

@ysfscream

  1. The scenario is that the MQTT broker is used to transfer files (read firmware updates). We know that MQTT was not meant to transfer files but it does support messages up to 256MB :) and so it was quick and cheap way to do it.
  2. For uploading I haven't tried it but when file-messages, which are often retained, then opening MQTT X on the file topic causes it to freeze for multiple minutes or even crash.

@ysfscream
Copy link
Member

OK. Thanks for your details. We will optimize this data display, but you can wait for the large file transfer function of EMQX, which will work very well for you!

@ysfscream ysfscream moved this to To Do in MQTTX May 25, 2023
@ysfscream ysfscream added this to MQTTX May 25, 2023
@TommyDuc TommyDuc changed the title [Feature] Add the option to automtically collapse large messages [Feature] Add the option to automatically collapse large messages May 31, 2023
@ysfscream ysfscream removed this from MQTTX Jul 14, 2023
@ysfscream ysfscream added this to MQTTX Jul 14, 2023
@ysfscream ysfscream moved this to Backlog in MQTTX Jul 14, 2023
@ysfscream ysfscream moved this from Backlog to TO DO in MQTTX Apr 12, 2024
@ysfscream ysfscream added this to the v1.10.0 milestone Apr 12, 2024
@ysfscream ysfscream moved this from TO DO to In Progress in MQTTX Apr 12, 2024
@ysfscream ysfscream moved this from In Progress to TO DO in MQTTX Apr 16, 2024
@ysfscream ysfscream moved this from TO DO to In Progress in MQTTX Apr 16, 2024
@ysfscream
Copy link
Member

It's updated to https://github.com/emqx/MQTTX/releases/tag/v1.10.0, welcome to try and thanks again.

@github-project-automation github-project-automation bot moved this from In Progress to Done in MQTTX Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop feature This pr is a feature web MQTTX Web
Projects
Status: Done
Development

No branches or pull requests

4 participants