Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify traversal schemes #148

Closed
aalexandrov opened this issue Jan 18, 2016 · 1 comment
Closed

Unify traversal schemes #148

aalexandrov opened this issue Jan 18, 2016 · 1 comment
Assignees
@aalexandrov
Labels
IR MACROS
Milestone
Jan 2016

Comments

@aalexandrov
Copy link
Contributor

This is a sub-issue as part of #147. Work in progress can be tracked here.

At the moment, traversal of Emma-specific IR is top-down. To make this consistent with normal Scala trees, the traversal schemes need to be rewritten so they work bottom-up.
@aalexandrov aalexandrov self-assigned this Jan 18, 2016
@aalexandrov aalexandrov added this to the Jan 2016 milestone Jan 18, 2016
@aalexandrov
Copy link
Contributor Author

Closing this as a wontfix. It turns out that we were using a bottom-up traversal scheme everywhere already. At the end I just re-implemented the foreach on top of the ExpressionTraverser in 1696151.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalexandrov aalexandrov

Labels
IR MACROS
Projects
None yet
Milestone
Jan 2016
Development

No branches or pull requests
1 participant
@aalexandrov