From 55def40bdac4d6fb1ad812aad2edc76c2a042037 Mon Sep 17 00:00:00 2001 From: Marine Dunstetter Date: Wed, 20 Mar 2024 16:31:49 +0100 Subject: [PATCH] feat(vite query-params): prevent vite QP to be passed to core logic -> when asking for a virtual content --- packages/vite/src/resolver.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/vite/src/resolver.ts b/packages/vite/src/resolver.ts index f87c3a3e60..21fefd5962 100644 --- a/packages/vite/src/resolver.ts +++ b/packages/vite/src/resolver.ts @@ -1,5 +1,5 @@ import type { Plugin, ViteDevServer } from 'vite'; -import { virtualContent, ResolverLoader } from '@embroider/core'; +import { cleanUrlQueryParams, virtualContent, ResolverLoader } from '@embroider/core'; import { RollupModuleRequest, virtualPrefix } from './request'; import assertNever from 'assert-never'; import makeDebug from 'debug'; @@ -52,7 +52,10 @@ export function resolver(): Plugin { }, load(id) { if (id.startsWith(virtualPrefix)) { - let { src, watches } = virtualContent(id.slice(virtualPrefix.length), resolverLoader.resolver); + let { src, watches } = virtualContent( + cleanUrlQueryParams(id.slice(virtualPrefix.length)), + resolverLoader.resolver + ); virtualDeps.set(id, watches); server?.watcher.add(watches); return src;