upgrading from 0.0.13 to 0.0.14 breaks tests #44
Comments
|
0.0.11 updated fastboot dependency to 2.x. There's currently an incompatibility issue with fastboot 2.x and ember-fetch. See: ember-cli/ember-fetch#184 and ember-fastboot/ember-cli-fastboot#686 A best workaround for now is to lock fastboot to 1.x, by adding this to your package.json: "resolutions": {
"fastboot": "^1.2.1"
} |
|
Oh wow, in Let me make a new release that sets the FastBoot version back to |
|
Actually, I tried upgrading first |
|
Ok, so just to confirm |
|
fwiw in my app it was the 0.0.11 and the update to fastboot 2.x. That resulted in "abortcontroller-polyfill/dist/cjs-ponyfill" error on build time. @0xadada case might be different, since it seems that's a runtime error (with a failed assertion and an infinite rendering) |
|
Thanks @CvX - You used yarn resolutions to fix it? |
That's right. I'm currently using ember-cli-fastboot-testing 0.0.14 and fastboot locked via resolutions to "^1.2.1". |
Yup, going from |
|
@ryanto @CvX the package versions output by $ grep '"version"' -B 1 node_modules/*fastboot*/package.json
node_modules/ember-cli-fastboot-testing/package.json- "name": "ember-cli-fastboot-testing",
node_modules/ember-cli-fastboot-testing/package.json: "version": "0.0.13",
--
node_modules/ember-cli-fastboot/package.json- "name": "ember-cli-fastboot",
node_modules/ember-cli-fastboot/package.json: "version": "2.0.4",
--
node_modules/fastboot-express-middleware/package.json- "name": "fastboot-express-middleware",
node_modules/fastboot-express-middleware/package.json: "version": "1.2.0",
--
node_modules/fastboot-transform/package.json- "name": "fastboot-transform",
node_modules/fastboot-transform/package.json: "version": "0.1.3",
--
node_modules/fastboot/package.json- "name": "fastboot",
node_modules/fastboot/package.json: "version": "1.2.1", |
|
Ok great. Thanks for the detailed info! I added some new features related to network requests in 0.0.14 that probably need some better tests. I'll get that fixed, but for now use |
0xadada
changed the title
|
@ryanto if you point me in the right direction, i could potentially add some tests later this week. |
|
@ryanto oh whoa, i found something even more interesting: If i run version $ ember test --filter "FastBoot | Welcome" # PASSes test
$ COVERAGE=true ember test --filter "FastBoot | Welcome" # PASSes testversion $ ember test --filter "FastBoot | Welcome" # PASSes test
$ COVERAGE=true ember test --filter "FastBoot | Welcome" # FAIL testthe error is as follows: I have a strong feeling that when ember-cli-code-coverage sends the coverage report back, it uses an AJAX request that has been modified to interact with fastboot.
|
|
Thanks @0xadada ! Edit: Removed my question because I saw you already answered it! |
|
@ryanto yup, heres the breakdown version $ ember test --filter "FastBoot | Welcome" # PASSes test
$ COVERAGE=true ember test --filter "FastBoot | Welcome" # PASSes testversion $ ember test --filter "FastBoot | Welcome" # PASSes test
$ COVERAGE=true ember test --filter "FastBoot | Welcome" # FAIL test |
|
Thanks! I just noticed you already answered that question above!!! I think I might have figured it out, can you do me a favor and try out this branch? #46 |
|
@ryanto yup, that worked 👌 🎉 |
|
Woooohoooooo!!!!! I'll cut a release once CI passes |
|
@ryanto out of curiosity, how do you start the app and step your debugger through this? some magickal incantation of |
|
@0xadada Yup, I made a video about this exact sort of thing! https://embermap.com/video/faster-node-debugging |
|
Alright this is fixed and released in |
|
Btw, thanks for doing all the debugging on this one @0xadada |
* chore(package): update ember-cli-fastboot-testing to version 0.0.15 * chore(package): update lockfile yarn.lock thanks to embermap/ember-cli-fastboot-testing#44 (comment)
|
I'm hitting this with the following: |
|
I believe the issue here is an undeclared dependency on |
|
Thanks runspired. What's the fix? Should we have |
|
@ryanto I think it needs be a dep but I forget if this library for ember-fetch was the culprit, I ended up ripping out ember-fetch and we're still testing with this library in ember-data so I'm guessing it was ember-fetch. |
My app uses
ember-fetch, so mypackage.jsondeclares:https://github.com/mirai-audio/mir/blob/4468041c729b3fc30cdfed8bd2f52ac6406f2a1e/package.json#L95-L97
my test is pretty basic:
https://github.com/mirai-audio/mir/blob/master/tests/fastboot/welcome-route-test.js
currently passes on
0.0.13, but going to0.0.14breaks the test.Details:
yarn produces the following relevant versions:
Reproduce
The repo is currently using this addon v0.0.13, so all you'd have to do to reproduce is just upgrade to
0.0.14and runember test --filter "FastBoot | Welcome"The text was updated successfully, but these errors were encountered: