From d03ff1f6ddab28884bcd51d7c70c5182fd8894b1 Mon Sep 17 00:00:00 2001
From: Sergio Arbeo <serabe@gmail.com>
Date: Fri, 4 Nov 2016 01:40:04 +0100
Subject: [PATCH] [FEATURE beta] Assert key in `Ember.get` is not empty

This adds an assertion to let the user know when they are using an empty
string as the key in `Ember.get`.

Addresses [this
comment](https://github.com/emberjs/ember.js/issues/14572#issuecomment-258202256) in #14572
---
 packages/ember-metal/lib/property_get.js         | 1 +
 packages/ember-metal/tests/accessors/get_test.js | 9 +--------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/packages/ember-metal/lib/property_get.js b/packages/ember-metal/lib/property_get.js
index 86f7d037c6c..c420c338597 100644
--- a/packages/ember-metal/lib/property_get.js
+++ b/packages/ember-metal/lib/property_get.js
@@ -52,6 +52,7 @@ export function get(obj, keyName) {
   assert(`Cannot call get with '${keyName}' on an undefined object.`, obj !== undefined && obj !== null);
   assert(`The key provided to get must be a string, you passed ${keyName}`, typeof keyName === 'string');
   assert(`'this' in paths is not supported`, !hasThis(keyName));
+  assert('Cannot call `Ember.get` with an empty string', keyName !== '');
 
   let value = obj[keyName];
   let desc = (value !== null && typeof value === 'object' && value.isDescriptor) ? value : undefined;
diff --git a/packages/ember-metal/tests/accessors/get_test.js b/packages/ember-metal/tests/accessors/get_test.js
index 23d4bbea176..17f8f44444c 100644
--- a/packages/ember-metal/tests/accessors/get_test.js
+++ b/packages/ember-metal/tests/accessors/get_test.js
@@ -39,14 +39,6 @@ QUnit.test('should not access a property more than once', function() {
   equal(count, 1);
 });
 
-QUnit.test('should be able to use an empty string as a property', function(assert) {
-  let obj = { '': 'empty string' };
-
-  let result = get(obj, '');
-
-  assert.equal(result, obj['']);
-});
-
 testBoth('should call unknownProperty on watched values if the value is undefined', function(get, set) {
   let obj = {
     count: 0,
@@ -114,6 +106,7 @@ QUnit.test('warn on attempts to use get with an unsupported property path', func
   expectAssertion(() => get(obj, undefined), /The key provided to get must be a string, you passed undefined/);
   expectAssertion(() => get(obj, false),     /The key provided to get must be a string, you passed false/);
   expectAssertion(() => get(obj, 42),        /The key provided to get must be a string, you passed 42/);
+  expectAssertion(() => get(obj, ''), /Cannot call `Ember.get` with an empty string/);
 });
 
 // ..........................................................