From c4b20e31a03c491d6ea71467e35c3fa1ccf01805 Mon Sep 17 00:00:00 2001 From: Doug Yun Date: Fri, 15 Apr 2016 15:06:16 -0400 Subject: [PATCH] [DOC beta] Update Route#loading example Fixes #13341 --- packages/ember-routing/lib/system/route.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/ember-routing/lib/system/route.js b/packages/ember-routing/lib/system/route.js index 441ae0f7cd5..23cdff9cd32 100644 --- a/packages/ember-routing/lib/system/route.js +++ b/packages/ember-routing/lib/system/route.js @@ -612,16 +612,12 @@ var Route = EmberObject.extend(ActionHandler, Evented, { App.ApplicationRoute = Ember.Route.extend({ actions: { loading: function(transition, route) { - var view = Ember.View.create({ - classNames: ['app-loading'] - }) - .append(); + let controller = this.controllerFor('foo'); + controller.set('currentlyLoading', true); - this.router.one('didTransition', function() { - view.destroy(); + transition.finally(function() { + controller.set('currentlyLoading', false); }); - - return true; // Bubble the loading event } } });