We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
there is a circular import between '@ember/object/index'; and '@ember/object/observable'; and @ember/array/index.
'@ember/object/index';
'@ember/object/observable';
@ember/array/index
those files are actually also importing from @ember/-internals/metal, so they could use that directly to access get, set
@ember/-internals/metal
get, set
https://github.com/emberjs/ember.js/blob/main/packages/%40ember/object/observable.ts#L14 https://github.com/emberjs/ember.js/blob/main/packages/%40ember/object/index.ts#L13
this causes rollup to sometimes build it wrong and have runtime errors later. (testing with vite+dep optimizer)
The text was updated successfully, but these errors were encountered:
cc @ef4
Sorry, something went wrong.
Fixed in #20734
No branches or pull requests
🐞 Describe the Bug
there is a circular import between
'@ember/object/index';
and
'@ember/object/observable';
and
@ember/array/index
.those files are actually also importing from
@ember/-internals/metal
, so they could use that directly to accessget, set
https://github.com/emberjs/ember.js/blob/main/packages/%40ember/object/observable.ts#L14
https://github.com/emberjs/ember.js/blob/main/packages/%40ember/object/index.ts#L13
this causes rollup to sometimes build it wrong and have runtime errors later. (testing with vite+dep optimizer)
The text was updated successfully, but these errors were encountered: