Uncaught TypeError when <base> tag doesnt have a href attribute

[emattias]

In storybook I get this error

Uncaught TypeError: Cannot read property 'replace' of null

on this line

ember.js/packages/@ember/-internals/routing/lib/location/history_location.ts

Line 124 in d96d9aa

baseURL = baseURL.replace(/\/$/, '');

because baseUrl is null and not a string like it look like that line is assuming.

The base tag looks like this (from here):

<base target="_parent">

solution suggestions

Would it work to change this line

ember.js/packages/@ember/-internals/routing/lib/location/history_location.ts

Line 81 in d96d9aa

baseURL = base.getAttribute('href');

to

      baseURL = base.getAttribute('href') || '';

or is there a problem with setting baseUrl to ''?

[rwjblue]

Hmm, I think the more appropriate solution here would be to treat having a <base> without an href as having no <base> at all. What do you think?