Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining skipped tests. #14170

Closed
12 of 16 tasks
rwjblue opened this issue Aug 31, 2016 · 2 comments
Closed
12 of 16 tasks

Fix remaining skipped tests. #14170

rwjblue opened this issue Aug 31, 2016 · 2 comments
Labels
Milestone

Comments

@rwjblue
Copy link
Member

rwjblue commented Aug 31, 2016

The following tests are currently skipped:

  • Ember.Application - visit() Integration Tests: SKIPPED: Test setup (0)
  • Ember.Application - visit() Integration Tests: SKIPPED: iframe setup (0)
  • [glimmer] append: no arguments (attaching to document.body): SKIPPED: appending, updating and destroying multiple components (0)
  • [glimmer] appendTo: a selector: SKIPPED: appending, updating and destroying multiple components (0)
  • [glimmer] appendTo: an element: SKIPPED: appending, updating and destroying multiple components (0)
  • [glimmer] renderToElement: no arguments (defaults to a body context): SKIPPED: appending, updating and destroying multiple components (0)
  • [glimmer] renderToElement: a div: SKIPPED: appending, updating and destroying multiple components (0)
  • [glimmer] Helpers test: closure {{action}} improved instrumentation: SKIPPED: action should fire interaction event (0)
  • [glimmer] Helpers test: closure {{action}} improved instrumentation: SKIPPED: interaction event subscriber should be passed parameters (0)
  • [glimmer] Helpers test: closure {{action}} improved instrumentation: SKIPPED: interaction event subscriber should be passed target (0)
  • [glimmer] Helpers test: {{render}}: SKIPPED: should render a template without a model only once (0)
  • [glimmer] Helpers test: {{unbound}}: SKIPPED: helper form updates on parent re-render (0)
  • [glimmer] outlet view: SKIPPED: should render the outlet when set after DOM insertion (0)Rerun
  • [glimmer] outlet view: SKIPPED: should support bound outlet name (0)
  • system/props/events_test: SKIPPED: DEPRECATED: adding didInitAttrs as a listener is deprecated (0)
  • Routing with Query Params: SKIPPED: can opt into full transition by setting refreshModel in route queryParams when transitioning from child to parent when all configuration is on route (0)
@rwjblue rwjblue added this to the 2.9.0 milestone Aug 31, 2016
@chancancode
Copy link
Member

FWIW, the two visit tests are legitimate pending features unrelated to Glimmer – they are not yet supported, but probably something we want to do at some point

@rwjblue
Copy link
Member Author

rwjblue commented Sep 4, 2016

Leaving the unbound test for #13946, I'm going to close this since all rendering related skipped tests have been reenabled.

@rwjblue rwjblue closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants