Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we make lookupFactory public on ContainerProxyMixin? #13065

Closed
workmanw opened this issue Mar 8, 2016 · 2 comments
Closed

Can we make lookupFactory public on ContainerProxyMixin? #13065

workmanw opened this issue Mar 8, 2016 · 2 comments

Comments

@workmanw
Copy link

workmanw commented Mar 8, 2016

I'm not sure if this would be more appropriate as an RFC issue, if so I'd be happy to move it over there.

With ember-data-model-fragments we have to rely on the private varation _lookupFactory to lookup fragment classes, see: ember-data-model-fragments/.../ext.js

This was part of the container API originally. And I know that was private and also we don't want to encourage users to be instantiating their own instances, but this is something we could really use for addons.
@stefanpenner
Copy link
Member

Ya feature requests are rfc or rfc isshes

@workmanw
Copy link
Author

workmanw commented Mar 8, 2016

I wasn't sure because there are a few issues of this nature still open eg #13039. But I'm happy to open this in the RFC repo.

@workmanw workmanw mentioned this issue Mar 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanpenner @workmanw