Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11% size increase in built ember.js file size on Jun 7 #11494

Closed
ilkkao opened this issue Jun 17, 2015 · 5 comments
Closed

11% size increase in built ember.js file size on Jun 7 #11494

ilkkao opened this issue Jun 17, 2015 · 5 comments

Comments

@ilkkao
Copy link
Contributor

ilkkao commented Jun 17, 2015

I created a chart which currently tracks the size of built ember.prod.js file.

It shows that on June 7th, #11367 got merged and the file size increased to 1809.631 kB from 1617.784 kB (~ +11%) Similar bump happened also in ember.min.js file size.

It would be good check if there's a way to avoid and undo it.

@rwjblue @mixonic

@rwjblue
Copy link
Member

rwjblue commented Jun 17, 2015

Thanks for spotting and reporting. I'll try to dig in and see what is going on...

@ilkkao
Copy link
Contributor Author

ilkkao commented Jun 17, 2015

@rwjblue
Copy link
Member

rwjblue commented Jun 18, 2015

@ilkkao - I have reopened just to make sure all is well. Can you confirm it is fixed, and close?

@stefanpenner
Copy link
Member

@ilkkao nice chart!

@ilkkao
Copy link
Contributor Author

ilkkao commented Jun 18, 2015

Thanks to @davidpett all release channels are tracked now.

I can verify that the canary release is now back at 472 kB after the fix from @rwjblue. Issue solved.

@ilkkao ilkkao closed this as completed Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants