Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION] currentURL() broken for acceptance testing in ember 1.12 #11175

Closed
toranb opened this issue May 15, 2015 · 10 comments
Closed

[REGRESSION] currentURL() broken for acceptance testing in ember 1.12 #11175

toranb opened this issue May 15, 2015 · 10 comments

Comments

@toranb
Copy link
Contributor

toranb commented May 15, 2015

I have a great deal of tests that check the current url like so and upgrading to ember.js 1.12 seems to have broken this. After the upgrade each url is "" (empty string) for some odd reason. Is this deprecated/removed/broken ?

   visit("/foo");
   click("button.edit");
   andThen(function () {
        assert.equal(currentURL(), "/foo/edit/1");
    });

I didn't see any mention of it in the blog post about 1.12 so I assumed it wasn't planned

http://emberjs.com/blog/2015/05/13/ember-1-12-released.html

thank you in advance

@toranb toranb changed the title [REGRESSION] CurrentURL() broken for acceptance testing in ember 1.12 [REGRESSION] currentURL() broken for acceptance testing in ember 1.12 May 15, 2015
@toranb
Copy link
Contributor Author

toranb commented May 15, 2015

note: just built a completely new ember app using ember-cli 0.2.4 and this is not a problem.

I'll investigate further to see why all of our internal apps fail when we upgrade :)

@mixonic
Copy link
Member

mixonic commented May 15, 2015

@toranb I believe this is a known issue with a ticket somewhere, cannot find it.

@toranb
Copy link
Contributor Author

toranb commented May 15, 2015

Found a related ticket that @rwjblue is already working on it seems

#10784

@tcjr
Copy link

tcjr commented May 15, 2015

Are you using location: 'auto'? If so, it could be related to this: #10943

@toranb
Copy link
Contributor Author

toranb commented May 15, 2015

In the broken app I'm using location hash. In the new ember-cli app I tried both auto and hash and it seemed to make no difference.

@dustinfarris
Copy link

Fails in a brand new app with ember-cli: ember-cli/ember-cli#4097

@elskwid
Copy link
Contributor

elskwid commented May 18, 2015

@toranb - take a look at the proposed PR above (#11201) - I ran into this exact issue today and couldn't stop digging. It "fixes" the issue for me but more eyes on the code would make me feel better.

@rwjblue
Copy link
Member

rwjblue commented May 18, 2015

Fixed by #11201. Thanks @elskwid!

@rwjblue rwjblue closed this as completed May 18, 2015
@toranb
Copy link
Contributor Author

toranb commented May 18, 2015

Awesome! any plans for a 1.12.1 release this week @rwjblue ?

@rwjblue
Copy link
Member

rwjblue commented May 18, 2015

There will be a release, not sure exactly when. We have a small number of other regressions that need to be fixed also. In the meantime you should be able to use bower install --save ember#release (which is always the latest build of the release channel) to get the fix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants