Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling subdirectories in ember-htmlbars-component-generation #10456

Closed
asakusuma opened this issue Feb 13, 2015 · 8 comments
Closed

Handling subdirectories in ember-htmlbars-component-generation #10456

asakusuma opened this issue Feb 13, 2015 · 8 comments
Labels

Comments

@asakusuma
Copy link
Contributor

If I have a handlebars component:

{{home/home-page}}

How do I express this with ember-htmlbars-component-generation? This does not work:

<home/home-page></home/home-page>

Edit: here is the error

Invalid end tag: closing tag must not have attributes, in `home` (on line 1).
Error: Invalid end tag: closing tag must not have attributes, in `home` (on line 1).
@sberan
Copy link

sberan commented Mar 3, 2015

I did a brief tour of the component syntax, and didn't see any way of instantiating a nested component in a directory. My preference would be to use <folder1:folder2:my-component> to traverse directories.

@sberan
Copy link

sberan commented Mar 3, 2015

relevant discussion: emberjs/rfcs#10 (comment)

@ballPointPenguin
Copy link

A part-way solution might be to resolve the component location by checking the folder in which the template that uses it resides, and if not found there, falling back to /components.
e.g. if I have app/pages/navigation-bar/component.js & app/pages/navigation-bar/template.hbs,
then I could just use <navigation-bar /> with my app/pages/template.hbs.

@chadhietala
Copy link
Contributor

@rwjblue A solution to this might be to just introduce the is attribute from the web components spec. For example you could do.

<td is="my-component"></td> 
<!-- or -->
<div is="path/to/my-component"></div>

cc/ @wycats @tomdale

@rwjblue
Copy link
Member

rwjblue commented May 30, 2015

Yep. That was definitely one of the ideas being tossed around.

I believe that @ebryn is opposed to 'is' though (I could be mistaken)...

@mixonic mixonic removed this from the 1.13.0 milestone Jun 7, 2015
@mixonic
Copy link
Member

mixonic commented Jun 7, 2015

This feature is not enabled in 1.13, we've removed this from the milestone.

@rwjblue
Copy link
Member

rwjblue commented Aug 10, 2015

Still need to determine how this will be handled in angle-bracket land.

@wycats - ping....

@rwjblue rwjblue mentioned this issue Aug 10, 2015
20 tasks
@rwjblue
Copy link
Member

rwjblue commented Apr 13, 2016

This feature was removed (so that work could continue on glimmer 2 engine). When the new angle bracket component RFC is introduced, please raise this concern there....

@rwjblue rwjblue closed this as completed Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants