Use "ember-new-computed" to polyfill new CP syntax #337
Conversation
|
|
||
| var dateComputed = function() { | ||
| return Ember.computed( | ||
| return computed({ set: |
There was a problem hiding this comment.
Can the set be on the same line as its function? Same as https://github.com/rwjblue/ember-new-computed#usage
|
@salzhrani thanks for this! I left some comments. |
|
Updated. |
| } | ||
| return null; | ||
| } | ||
| ).property(); | ||
| }).property(); |
There was a problem hiding this comment.
No need to call .property on the return value of ember-new-computed. It is already a computed property descriptor...
|
👍 |
Use "ember-new-computed" to polyfill new CP syntax
|
Awesome! |
|
I am confused about |
|
@salzhrani it's not part of the Ember app, but it is part of this repo. The inspector is made up of two separate parts, an Ember app (which is the one you see in the devtools panel when using the inspector) and an injected script (everything under |
and minor indentation fix