Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.26.6 still transpiling to use Ember global #408

Closed
alexlafroscia opened this issue May 27, 2021 · 2 comments
Closed

7.26.6 still transpiling to use Ember global #408

alexlafroscia opened this issue May 27, 2021 · 2 comments

Comments

@alexlafroscia
Copy link
Contributor

alexlafroscia commented May 27, 2021

Hello! I've been trying to upgrade our app to Ember 3.27 for a few days but keep running into errors about using the Ember global.

I am using Yarn resolutions to ensure that only [email protected] is installed, even for addons that are using out-of-date versions of that package (I checked each addon individually to see if they did any custom Babel stuff, and none of them do, so this seems... safe enough?). This has been working fine up until Ember 3.27.

Now, I am getting errors related to the Ember global being used. For example, this line of code from Ember Data:

https://github.com/emberjs/data/blob/master/packages/store/addon/-private/system/promise-proxies.js#L44

ends up transpiled into Ember.computed.reads which, apparently, is no longer a function at all, causing an exception to be thrown.

My understanding is that [email protected], when used with Ember 3.27, should not transpile code to use the Ember global. Is there some way I can hunt down why this is not behaving that way?

@rwjblue
Copy link
Member

rwjblue commented May 28, 2021

Please double check to ensure you are on the latest version of ember-data. Specifically you need emberjs/data#7527 which was back ported in emberjs/data#7552 and released in 3.27.1 (released yesterday).

@alexlafroscia
Copy link
Contributor Author

Yup, that did it! Thanks @rwjblue and @runspired 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants