Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Setting hasMany relationship IDs to an array with duplicate IDs should error #9119

Closed
gitKrystan opened this issue Nov 16, 2023 · 1 comment
Closed

bug: Setting hasMany relationship IDs to an array with duplicate IDs should error #9119

gitKrystan opened this issue Nov 16, 2023 · 1 comment
Labels
🏷️ bug This PR primarily fixes a reported issue lts-4-12 Long Term LTS Maintenance

Comments

@gitKrystan
Copy link
Contributor

gitKrystan commented Nov 16, 2023 •
edited
Loading

Issue confirmed in 4.12

As of version 4.6, duplicate records added to ManyArrays were de-duped. This unspecified behavior was accidentally removed in 4.12+.
@github-project-automation github-project-automation bot moved this to needs triage in EmberData Nov 16, 2023
@gitKrystan gitKrystan added the 🏷️ bug This PR primarily fixes a reported issue label Nov 16, 2023
@runspired runspired moved this from needs triage to needs champion in EmberData Nov 17, 2023
@runspired runspired added the lts-4-12 Long Term LTS Maintenance label Nov 17, 2023
@runspired runspired mentioned this issue Nov 18, 2023
Merged
8 tasks
@runspired
Copy link
Contributor

We've landed the fixes for 4.12 but need to do the same for main and 5.3

@gitKrystan gitKrystan mentioned this issue Dec 21, 2023
Merged
@gitKrystan gitKrystan mentioned this issue Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏷️ bug This PR primarily fixes a reported issue lts-4-12 Long Term LTS Maintenance
Projects
EmberData
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@runspired @gitKrystan