Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we make detectMerge and/or __configureMerge public #7188

Closed
igorT opened this issue May 13, 2020 · 2 comments
Closed

Should we make detectMerge and/or __configureMerge public #7188

igorT opened this issue May 13, 2020 · 2 comments
Labels
team-review

Comments

@igorT
Copy link
Member

igorT commented May 13, 2020

No description provided.

@igorT
Copy link
Member Author

igorT commented May 13, 2020

As #7182 showed, there might be a need to configure merging strategies, but it's unclear whether we should expose the current configure merge mechanism, as you might need to configure detecting merge as well.
@runspired mentioned calling it handlePotentialConflict or something like that

@runspired
Copy link
Contributor

We ended up finding use-case for the cache knowing when this has occurred and added an operation to the cache RFC (in lieu of a hook) emberjs/rfcs#854. We do not believe we need the hook to be public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@runspired @igorT