Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra toString based assertion #4615

Closed
stefanpenner opened this issue Oct 21, 2016 · 2 comments
Closed

extra toString based assertion #4615

stefanpenner opened this issue Oct 21, 2016 · 2 comments
Assignees
@stefanpenner
Labels
🏷️ cleanup This PR primarily removes deprecated functionality

Comments

@stefanpenner
Copy link
Member

putting this here to remember:
#4597 (comment)
@stefanpenner stefanpenner self-assigned this Oct 21, 2016
@stefanpenner stefanpenner mentioned this issue Oct 21, 2016
Merged
5 tasks
@wecc wecc added the Cleanup label Oct 24, 2016
@runspired
Copy link
Contributor

I believe that now that no-double-extend is a thing and Ember.Object is based on classes that we are able to do nice things with toString. There's even a PR #5117 :)

@runspired
Copy link
Contributor

Nice things done.

@runspired runspired added 🏷️ cleanup This PR primarily removes deprecated functionality and removed Cleanup labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanpenner stefanpenner

Labels
🏷️ cleanup This PR primarily removes deprecated functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanpenner @runspired @wecc