Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isUpdating is broken since 2.4.3 #4339

Closed
concertiv opened this issue Apr 17, 2016 · 4 comments · Fixed by #4386
Closed

isUpdating is broken since 2.4.3 #4339

concertiv opened this issue Apr 17, 2016 · 4 comments · Fixed by #4386
Assignees
Labels
🏷️ bug This PR primarily fixes a reported issue

Comments

@concertiv
Copy link

concertiv commented Apr 17, 2016

Prior to version 2.5.0, we used isUpdating to determine the loading state of an ArrayProxy resulting from findAll. The reason for using isUpdating is that other states, such as isFulfilled, were not triggered during background loads.

To be clear, since version 2.5.0, isUpdating returns false when it used to return true. It used to return true when: (1) the findAll promise was resolving, where reload: true was set, and (2) the records were being (re)loaded in the background for ordinary findAll operations.

Did we miss an API change, or perhaps is there a better way of tracking the loading state of an ArrayProxy resulting from a find operation?

@pangratz pangratz self-assigned this May 16, 2016
@pangratz pangratz added the Bug label May 16, 2016
@pangratz
Copy link
Member

pangratz commented May 16, 2016

Looks like this regression has been introduced in #4316 in this line. I am working on a fix.

@pangratz
Copy link
Member

@kbbpartners this regression should be fixed once #4386 is merged and a new version 2.5.3 is released. Many thanks for reporting this and sorry for the inconvenience.

@pangratz
Copy link
Member

@kbbpartners FYI, ember-data v2.5.3 has been released...

@concertiv
Copy link
Author

Looks good. Our loading indicators are back! Thank you.

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants