Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-plugin-feature-flags name collision in 2.5.1 with fastboot #4322

Closed
davidpett opened this issue Apr 12, 2016 · 4 comments
Closed

babel-plugin-feature-flags name collision in 2.5.1 with fastboot #4322

davidpett opened this issue Apr 12, 2016 · 4 comments

Comments

@davidpett
Copy link

When updating to version 2.5.1 and running ember s I received the following error:

File: modules/ember-data/adapter.js
The Broccoli Plugin: [Babel] failed with:
ReferenceError: The plugin "babel-plugin-feature-flags" collides with another of the same name

After some digging, @pangratz found that because I am using ember-cli-fastboot there is a collision in the plugins. You can reproduce the issue with these steps:

ember new abcd
cd abcd
ember build # works as expected

ember install ember-cli-fastboot
ember build # throws ReferenceError: The plugin "babel-plugin-feature-flags" collides with another of the same name
@fivetanley
Copy link
Member

This should be fixed once we change the approach in ember-cli-fastboot ember-fastboot/ember-cli-fastboot#145

@rwjblue
Copy link
Member

rwjblue commented Apr 13, 2016

#4328 seems like the correct fix for ember-data itself (though I do think that fastboot PR is also the correct direction).

@davidpett
Copy link
Author

To be able to use this fix, do i need to run on master? or will release include it?

@rwjblue
Copy link
Member

rwjblue commented Apr 14, 2016

Release will include it, but I don't think it's been cherry picked yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants