Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"serializer" blueprint should support different base classes #4266

Closed
Turbo87 opened this issue Mar 27, 2016 · 3 comments
Closed

"serializer" blueprint should support different base classes #4266

Turbo87 opened this issue Mar 27, 2016 · 3 comments

Comments

@Turbo87
Copy link
Member

Turbo87 commented Mar 27, 2016

The "adapter" blueprint supports the --base-class option and automatically detects if an "application" adapter exists. IMHO the same logic should be reused for the "serializer" blueprint too.

@pangratz
Copy link
Member

This is tackled in #4023. Can you chime in there? Currently the failing test for the serializer prevents that PR from being merged. I think the test is failing because the blueprint from ember-cli is used instead of the one provided in ember-data...

@Turbo87
Copy link
Member Author

Turbo87 commented Mar 27, 2016

@pangratz thanks, didn't see that one

@pangratz
Copy link
Member

Yeah, the title of that PR is not that descriptive 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants