Upgrade from 1.13.8 to 1.13.11 breaks our app

[tschoartschi]

Basically we display a catalog with tags and items. Therefore we fetch the data with ember-data and render it. With ember-data 1.13.8 everything worked fine but after an upgrade to 1.13.11 our catalog is broken. The strange thing is, it only effects some items. The effected items have the property type with value "configuration" (which is returned as as string from the server but is is a belongsTo relation). The model definitions look as follows:

The catalog model: app/models/catalog.js

export default DS.Model.extend({
    // some proprties, which are strippe due to readability
    // Relationships
    tenant: DS.belongsTo('tenant', {async: true}),
    items: DS.hasMany('item', {async: true}),
    allItems: DS.hasMany('item', {async: true, inverse: null}),
    components: DS.hasMany('component', {async: true}),
    materials: DS.hasMany('material', {async: true}),
    tags: DS.hasMany('tag', {async: true}),
    allTags: DS.hasMany('tag', {async: true}),
    rootTags: DS.hasMany('tag', {async: true}),
});

The item model: app/models/item.js

export default DS.Model.extend({
    // some proprties, which are strippe due to readability
    hidden: DS.attr('boolean'),
    sort: DS.attr('number'),

    // Relationships
    catalog: DS.belongsTo('catalog', {async: true, inverse: null}),
    detailType: DS.belongsTo('detailType', {async: true, inverse: null}),
    type: DS.belongsTo('objectType', {async: true, inverse: null}),
    tags: DS.hasMany('tag', {async: true, inverse: null})
});

The tag model: app/models/tag.js

export default DS.Model.extend({
    // some proprties, which are strippe due to readability
    // Relationships
    catalog: DS.belongsTo('catalog', {async: true, inverse: null}),
    tags: DS.hasMany('tag', {inverse: null}),
    parents: DS.hasMany('tag', {inverse: null}),
    items: DS.hasMany('item', {async: true, inverse: null}),
});

At first we fetch the catalog, then we iterate over the tags of the catalog and then we fetch all items belonging to each tag. Everything works fine, except items which have a type configuration, these items don't have any properties, only the id is set. So we can not access properties like sortor hidden. Until version 1.13.8 of ember-data we had no issues and every property was available (also on items with type === "configuration"). Downgrading from 1.13.11 to 1.13.8 fixes this issue but I don't like the idea that we can not update anymore. Did we discovered some edge case in ember-data or is it just some misconfiguration from our side?

We use ember-cli 1.13.8 with ember 1.13.10 and we want to use ember-data 1.13.11 or .12. Right now we can just use ember-data 1.13.8.

If you need more information to track down this problem, let me know.

All the best
Tschoartschi

[rwjblue]

Seems related to:

• [BUGFIX release-1-13] Disable polymorphic deserialization when a mode… #3725
• type attribute breaks things #3731
• DS.Model type property name in non-polymorphic models #3702

[tschoartschi]

@rwjblue okay thanks for your quick reply. Do you need more information or is it ok for now?

[bmac]

Hi @tschoartschi. It looks like #3725 should solve this issue. That pr was included in 1.13.12. Do you mind upgrading to that version and letting us know if it fixes your issue?

[tschoartschi]

@bmac version 1.13.12 seems to fix the issue. I thought that I tried it before opening this issue but maybe I forgot to upgrade the version in package.json or bower.json. I don't know. Most importantly it works again 👍 thanks for all your efforts!