Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta not available in 1.13.3 #3401

Closed
raytiley opened this issue Jun 21, 2015 · 5 comments
Closed

meta not available in 1.13.3 #3401

raytiley opened this issue Jun 21, 2015 · 5 comments

Comments

@raytiley
Copy link

The meta object that usually gets passed through from query calls is an empty object on 1.13.3. This essentially has broken all the pagination in my app. I see there was a recent fix on master regarding meta: #3398, but I can't tell if it just applies to the new JSONAPI sterilization stuff or not.

@rounders
Copy link

I can also confirm that pagination on my app no longer works since upgrading to 1.13.3.

@wecc
Copy link
Contributor

wecc commented Jun 21, 2015

store.metadataFor and queryResults.get('meta') is broken in 1.13.3 if you're using the new Serializer API. The new Serializer API is active when you 1.) are using default uncustomized serializers, 2) by setting isNewSerializerAPI or 3) if you're using the new JSON-API adapter/serializer.

#3398 solves this for all serializers, not only the JSON-API one. This JSBin works with canary but not with release.

@wecc
Copy link
Contributor

wecc commented Jun 29, 2015

@raytiley @rounders can you confirm if 1.13.4 works better?

@rounders
Copy link

@wecc working well for me in 1.13.4 ❤️ Thanks!

@wecc
Copy link
Contributor

wecc commented Jun 29, 2015

🎉

@wecc wecc closed this as completed Jun 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants