Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordArray#addRecord is unused #3153

Closed
bmac opened this issue Jun 2, 2015 · 3 comments · Fixed by #3156
Closed

RecordArray#addRecord is unused #3153

bmac opened this issue Jun 2, 2015 · 3 comments · Fixed by #3156

Comments

@bmac
Copy link
Member

bmac commented Jun 2, 2015

@igorT can this code be removed?

/**
Adds a record to the `RecordArray` without duplicates
@method addRecord
@private
@param {DS.Model} record
@param {DS.Model} an optional index to insert at
*/
addRecord: function(record, idx) {
var content = get(this, 'content');
if (idx === undefined) {
content.addObject(record);
} else if (!content.contains(record)) {
content.insertAt(idx, record);
}
},

@igorT
Copy link
Member

igorT commented Jun 2, 2015

do we use removeRecord?

@bmac
Copy link
Member Author

bmac commented Jun 2, 2015

yes

@sly7-7
Copy link
Contributor

sly7-7 commented Jun 2, 2015

@bmac It turns out that recordArrayManager uses the deprecated _pushRecord. So I think this could be closed as soon as I remove the deprecated function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants