Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We wrongly assert that relationships, relationshipsByName, relatedTypes are reserved props on model #2948

Closed
igorT opened this issue Mar 27, 2015 · 2 comments · Fixed by #2953
Closed

We wrongly assert that relationships, relationshipsByName, relatedTypes are reserved props on model #2948

igorT opened this issue Mar 27, 2015 · 2 comments · Fixed by #2953

Comments

@igorT
Copy link
Member

igorT commented Mar 27, 2015

They are not, they are defined on the class not on the instances.
We should assert for eachRelationship, relationshipFor, inverseFor instead
cc @bmac
cc @omarestrella
@bmac bmac mentioned this issue Mar 27, 2015
Merged
@omarestrella
Copy link

Thanks for the quick fix! This really bit us when trying to upgrade.

@bmac
Copy link
Member

bmac commented Mar 30, 2015

Sorry about that @omarestrella.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not assert reserved properties for static properties. bmac/data
3 participants
@bmac @omarestrella @igorT